Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Head of line blocking when sending a large video file #8734

Closed
4 tasks done
link2xt opened this issue Apr 1, 2019 · 2 comments
Closed
4 tasks done

Head of line blocking when sending a large video file #8734

link2xt opened this issue Apr 1, 2019 · 2 comments

Comments

@link2xt
Copy link

link2xt commented Apr 1, 2019

Bug description

When I send large videofile (or probably any large file) to the chat, followed by some text messages, the messages stay in the queue until the file is uploaded.

Steps to reproduce

  • Create a large file, possibly by recording a 1 minute video
  • Send video file to a chat (I tested with a group chat, should probably work for other types of chat as well)
  • Send a text message while the video file is uploading (a circular progress bar is displayed on top of the videofile preview)

Actual result: Text message is waiting in the queue until the videofile is uploaded.
Expected result: Text message is sent immediately and the videofile contents is uploaded in the background

Device info

Signal version: 4.36.2

I have not checked if there are technical limitations that prevent this kind of reordering. Maybe protocol changes are required. But given that it is possible not to download the file and still receive messages, I think it should be possible to send messages without actually uploading the whole content of the previously sent file.

@greyson-signal
Copy link
Contributor

This is intended. Signal messages hold pointers to the attachments that are paired with them.

@link2xt
Copy link
Author

link2xt commented Apr 2, 2019

I have looked a bit into libsignal-service-java. Isn't it possible to reserve AttachmentPointer before actually uploading the content? Key ratchet doesn't depend on the content of the attachment, so it should be possible to proceed without uploading the attachment itself, it would just not be available for download until upload is complete.

Clients can download attachments asynchronously, can't they upload them asynchronously too?

Was it considered and documented somewhere internally? Maybe I should submit a feature request to the support forum instead?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants