Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds content descriptions for in-call buttons #11977

Closed
wants to merge 1 commit into from

Commits on Feb 9, 2022

  1. Adds content descriptions for in-call buttons

    Fixes signalapp#9774
    
    Previously, when in a WebRTC call and using Talkback, the dailer
    buttons would read, from right to left:
    - unlabelled button
    - (on/off) switch
    - (on/off) switch
    - unlabelled button (when showing flip)
    
    now, when in a WebRTC call and using Talkback, with video and audio
    enabled, the dailer buttons will read (from right to left):
    - end call button
    - on unmute switch
    - on camera switch
    - flip button
    
    when in a WebRTC call and using Talkback with video off and audio
    muted, the dailer buttons will read (from right to left):
    - end call button
    - off unmute switch
    - off camera switch
    - flip button
    
    I do think that it would likely be a better user experience if the
    "flip" button read "flip to front camera" or "flip to back camera"
    but it looks like that may be fairly complicated and above my
    skills at this time. As it seems like this issue has been open for
    a long time, maybe it's helpful to merge the initial PR, then have
    someone else follow up later?
    clado committed Feb 9, 2022
    Configuration menu
    Copy the full SHA
    addb564 View commit details
    Browse the repository at this point in the history