Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: UNDERLINE text effect underlines newline characters #12808

Closed
wants to merge 1 commit into from
Closed

Fix: UNDERLINE text effect underlines newline characters #12808

wants to merge 1 commit into from

Conversation

bijaykumarpun
Copy link
Contributor

@bijaykumarpun bijaykumarpun commented Feb 25, 2023 •
edited

First time contributor checklist

Contributor checklist

  • Pixel 4, API 30 Emulator
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

This PR fixes underline effect for newline characters, fixes #12807

Issue

(Notice the dots between lines)
issue

Fix

fix

nekorubu pushed a commit to nekorubu/Signal-You that referenced this pull request Mar 22, 2023
@bijaykumarpun
Fix incorrect underlines rendering for empty lines in image editor.
fd64175 
Fixes signalapp#12807
Closes signalapp#12808
TheTechZone pushed a commit to Cerenia/Signal-Android that referenced this pull request Apr 13, 2023
@bijaykumarpun @TheTechZone
Fix incorrect underlines rendering for empty lines in image editor.
6269066 
Fixes signalapp#12807
Closes signalapp#12808
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Media Editing - UNDERLINE text effect underlines newline characters
1 participant
@bijaykumarpun