Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow sending SMS/MMS on expired builds #5561

Closed
wants to merge 1 commit into from
Closed

Allow sending SMS/MMS on expired builds #5561

wants to merge 1 commit into from

Conversation

mhernz
Copy link

@mhernz mhernz commented Jul 3, 2016

Contributor checklist

  • I am following the Code Style Guidelines
  • I have tested my contribution on these devices:
    • Samsung Galaxy S5, Android 6.0.1 (CyanogenMod 13)
    • AVD Nexus 5X (x86_64)
  • My contribution is fully baked and ready to be merged as is
  • I have made the choice whether I want the BitHub reward or not by omitting or adding the word FREEBIE in my commit message

Description

There is no reason to block sending SMS/MMS messages on expired builds, since they are already completely unsecured and don't utilize the Signal protocol.

Related to #5493

// FREEBIE

@moxie0
Copy link
Contributor

moxie0 commented Jul 4, 2016

thanks but we're not going to do this

@moxie0 moxie0 closed this Jul 4, 2016
@mhernz mhernz deleted the expired-sms branch July 4, 2016 03:12
@jnathan jnathan mentioned this pull request Aug 8, 2016
Closed
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@mhernz @moxie0