Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow Signal installation in external storage #8417

Closed
wants to merge 1 commit into from

Conversation

tezeb
Copy link

@tezeb tezeb commented Dec 1, 2018

Contributor checklist

  • Samsung Galaxy A3, Android 8.0
  • Innos D10F, Android 7.1.2
  • My contribution is fully baked and ready to be merged as is
  • I ensure that all the open issues my contribution fixes are mentioned in the commit message of my first commit using the Fixes #1234 syntax

Description

Since Android API 8, it is possible to store apk file in external storage. This allows users of phones with low amount of internal memory to install more aps. To keep backward compatibility and allow the use of external storage only when android device supports it and user did configured it, the safe "auto" value is selected.
As Signal does not qualify in any of the "Should Not" categories listed here:
https://developer.android.com/guide/topics/data/install-location#ShouldNot
it should be perfectly safe to use.

Since Android API 8, it is possible to store apk file in external storage. This allows users of phones with low amount of internal memory to install more aps(as SD card is used for it). To keep backward compatibility and allow the use external storage only when user configured it, the safe "auto" value is selected.
As Signal does not qualify in any of the "Should Not" categories listed here:
https://developer.android.com/guide/topics/data/install-location#ShouldNot
it should be perfectly safe to use.
@greyson-signal
Copy link
Contributor

To the contrary, Signal uses several "Should Not" features:

  • Services
  • Alarm Services
  • Account Managers
  • Sync Adapters
  • Broadcast Receivers listening for "boot completed"

Thank you, but I think for now we're better off keeping things as they are.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants