Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only show outlines when using keyboard #2993

Closed
1 task done
anodos-z opened this issue Dec 21, 2018 · 2 comments
Closed
1 task done

Only show outlines when using keyboard #2993

anodos-z opened this issue Dec 21, 2018 · 2 comments

Comments

@anodos-z
Copy link

  • I have searched open and closed issues for duplicates

Bug Description

When clicking on buttons, it briefly adds focus to them which gives them an outline.
Clicking on the edges of navs will give them an outline too.
In the nav at the top right, it also adds an outline around the ‘Disappearing messages’ menu, even if it is not open.

Actual Result:
Clicking shows an outline.

Expected Result:
Clicking should not show an outline, but outlines should appear when using the tab key.

Screenshots

1-focus_before
sig-outline-1
sig-outline-2

Platform Info

Signal Version: v1.19.0

Operating System: Windows 10 1809

_

I found one possible solution to this written here.
(Using event listeners to check for the mouse button/tab key, and adding or removing the outlines accordingly.)

I tested this and it works:
2-focus_after

But I don't know if it’s the best solution.

@zznidar
Copy link
Contributor

zznidar commented Dec 26, 2018

The second part of the issue mentioned (Disappearing messages not opening on click) is related to #2601

@scottnonnenberg-signal scottnonnenberg-signal changed the title Outlines appear when clicking on buttons and navs Only show outlines when using keyboard Jan 2, 2019
@stale
Copy link

stale bot commented Sep 28, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

4 participants