Signal on windows 7 has no sound options

[lawssy]

Hi, I'm wondering why my signal desktop doesn't have any sound options under notifications. My buddies which is using signal has a tick box to enable or disable sound notification. Is it because I'm using windows 7.

Please refer to the attached photo.

Thanks

[josh-signal]

Looks like it's because the code disables it for that version of Windows: https://github.com/signalapp/Signal-Desktop/blob/development/ts/types/Settings.ts#L6 happened in this commit: ecf23b6b2

We might be able to enable that and notification grouping again since I believe the bugs have been resolved. A pull request along with some testing on Windows 7 is welcome.

[proxy-001]

Looks like the bug originally pointed in "ts/types/Settings.ts" as electron/electron#11189 was closed on 12 Jun 2019.
I have unpacked app.asar, changed "const MIN_WINDOWS_VERSION = '6.0.0';", packed asar back and now I have "Play audio notification" checkbox in settings. Will test for some time on OS version 6.1.7601 (Win7 x64 SP1).

[proxy-001]

changed "const MIN_WINDOWS_VERSION = '6.0.0';", packed asar back and now I have "Play audio notification" checkbox in settings. Will test for some time on OS version 6.1.7601 (Win7 x64 SP1).

Sound notifications sill does not work. Mod changed only visibility of checkbox.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[proxy-001]

Anyone interested to solve the issue?

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[proxy-001]

Still interested in sound notifications under Win7x64

[stale]

This issue has been closed due to inactivity.