New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Notification with tag works only once #11189
Comments
👋 Thanks for opening your first issue here! If you're reporting a 🐞 bug, please make sure you include steps to reproduce it. We get a lot of issues on this repo, so please be patient and we will get back to you as soon as we can. To help make it easier for us to investigate your issue, please follow the contributing guidelines. |
For clarity this is not a 1.8.x regression, it only occurs on Windows 7 and it's due to how we attempt to de-duplicate notification objects based on there tag in our windows 7 notification presenter |
We ran into this as well on the Signal Desktop app. Repro Code let counter = 0;
let intervalId = setInterval(
() => new Notification(counter++, { tag: "static-tag" }),
1000
); |
Grouping of notifications is not supported on Windows 7 due this bug: electron/electron#11189 * [x] Disable notification grouping (using `tag`) on Windows 7. * [x] Log notification grouping support. * [x] **Infrastructure:** Use 2-space indentation for all files (better integration with Prettier.)
Thank you for taking the time to report this issue and helping to make Electron better. The version of Electron you reported this on has been superseded by newer releases. If you're still experiencing this issue in Electron v2.0.x or later, please add a comment specifying the version you're testing with and any other new information that a maintainer trying to reproduce the issue should know. I'm setting the Thanks in advance! Your help is appreciated. |
Thank you for your issue! We haven't gotten a response to our questions in our comment above. With only the information that is currently in the issue, we don't have enough information to take action. I'm going to close this but don't hesitate to reach out if you have or find the answers we need, we'll be happy to reopen the issue. |
Hello, I just want to point out that I still get this bug on electron 4.1.4. I'm able to reproduce the bug with the the code @gasi-signal posted and a clean electron-quick-start-repo. Edit: When I actively close the notification new notifications will always popup. But when I wait for the notification to auto-dismiss next notifications with the same tag won't appear. So I guess the auto-close don't release it's resources? |
Just letting you know the bug is still present in 5.0.0. |
After creating a notification and passing a tag, then subsequent notifications with the same tag don't show up for the entire lifespan of the app.
Expected behavior
New notifications should open after the last one has closed.
Actual behavior
Nothing happens
How to reproduce
$ git clone https://github.com/electron/electron-quick-start .
$ npm install
$ npm start
Then in the app open dev tools and paste this in the console:
Wait for the notification to disappear and paste it again, observe nothingness.
The text was updated successfully, but these errors were encountered: