-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
All messages read in Signal-Desktop but not on Android #5052
Comments
Just had this again. It only happened in group conversations (2 of them), maybe that only happens in this case. desktop: https://debuglogs.org/dc1f0f0abd40d94f69f928fc78a312644f916b851b1e2f73879c27ca40fe4841 Android: 5.6.4 |
Thanks for sharing this. You may already know this, but devices send "read syncs" to each other, effectively telling your other devices that you've read a message. From your logs, I'm not sure whether Desktop is failing to send read syncs or if Android is failing to receive them. It'd be super helpful for us if you could get a reliable reproduction for this. It's helpful that it's happened in group conversations, but more specifics would be super useful. |
Nothing I can reproduce so far, and apparently it just happens once in a while so it's really low priority, I just want to document when it does happen, maybe I'll find a pattern eventually! |
Muted group. Phone was away so I'd guess the message was received later on Android than on Desktop. The message was marked as read after I had reacted to it from Desktop. Desktop Android, when message was not marked as read: I managed to reproduce it a few times. Nothing to do with the muted status. Interestingly, I had the case where the message was read on two linked devices: I read it on one, and it was then propagated to the other device, but not Android. This happens more when I used the battery saver on Android, which shouldn't allow Signal to run in the background. So the bug would be something to do with receiving the message after a manual wake-up. New example with the last Android version (5.8): android before reading: https://debuglogs.org/f46172af7177f9517934a4768190286b05004868c08729a5b63476b715521f90 android after reading: https://debuglogs.org/00c342efd3c2fa8dc9dffc38f472f3649bff3bbd8b9cec12a200b76808d1d6c8 |
If you foreground the android app, do you receive the read syncs? |
@greyson-signal no, that's the part which surprises me. |
Desktop: https://debuglogs.org/dc02287cb50aa7cc209de187ff7698e5b0c71bf0b904b6f0ba6eb547995df57f Android: https://debuglogs.org/5df295e155311d741e0b82335ae733f6b3a9a4cf35cc0adf87aa7a90858b3d76 3 messages from a group, sent at the same time from a contact. 2 messages marked as not read on Android. In the Desktop log,
I think the 2 last read syncs failed at some point. I should check whether this only happens with multiple messages, maybe the bug doesn't happen if messages are sent or received one by one. Other thing: when I open the group convo, it only said "1 unread message", contradicting the blue |
@hiqua What do you mean by "I think the 2 last read syncs failed at some point."? |
I just meant that since I had two messages unread and that the timestamps seemed to match, the 2 read sync mentioned are probably the ones that are either:
|
One thing you can do to make sure you're in good shape for a future bug report is: making sure both sides are at zero unread. We have seen issues in the past where Desktop might fail to send a read sync, and then Android would never go mark that old message read, leading to confusing conversation badges on Android. |
So you mean:
Is this what you mean? |
@hiqua Yes, essentially start over from the clean slate to figure out what's really causing it. |
Sorry I haven't spent much more time trying to reproduce the issue, but I just encountered it again, so here are logs in case you added more information in new versions. Before reading the faulty conversation:
After reading it on Android: |
@hiqua Thanks for the updated log. If you can provide the 'sent id' for the message that wasn't marked read properly, that will help us zero in on the log. As always, you can grab it by going to message details for that message and grabbing the number next to the sent timestamp. |
Ah yeah sorry I forgot. Here is the info: Conversation id: dd5 The three relevant messages:
See in desktop logs:
|
Okay, to confirm. You read the message on Desktop, but that's not being reflected on Android? Here are the three moments Desktop sent read syncs between its receipt of that first message you point to, and when it gets read sync messages from your Android:
Based on that log, it's like you didn't read that conversation. Or is one of those read sync sends for the conversation in question? |
Yup
The (truncated) conversation ID is The last one (from Android) matches the phone number, and it's one of the messages. I can confirm that the UI from Signal-Desktop was not indicating any unread message, but I didn't take screenshots, I'll try to do that next time. Also to try next time for me: check what's the status in another signal-desktop instance, and if I can read it there. Edit: for what it's worth, logs from another Signal-Desktop instance, after everything: https://debuglogs.org/96d4804d6158736f79d6a3fe42b68a155c770acefa7bf64569394de2b794173d.gz |
Just got another one, in a group. Message id: 1627596271094 Android before reading from Android: https://debuglogs.org/b58410de733d27fcd5f28baa5c196ca8d575616b102abee11800962fe693cf8c Desktop and Desktop beta agree with each other and consider everything as read, Android doesn't. |
v5.12.0-beta.1 has a change (see 18140c4) that will retry read syncs for ~24 hours. It seems like this might fix some of the problems you're having, as it seems like Desktop isn't fully sending read syncs in some cases. Does that sound right to you? |
Note that my previous comment mentions an occurrence of this bug on the version you're mentioning, v5.12.0-beta.1. So it looks like it doesn't fix it, at least not fast enough for me not to notice. Regarding the fix itself, since we don't really know the origin I can't really judge whether it will change anything. Since the other instance of Signal-Desktop marked the message as read I would tend to say it's a bug on the Android side. Since I have a LineageOS there, it's also expected that it's less tested overall, while I don't expect my Debian to be particularly surprising for Signal-Desktop. |
I seem to have the same issue. No read notifications are synced from the Desktop client to Android. My phone has Signal 5.21.5 and my Linux desktop machine is on 5.14. Debug logsDesktop: https://debuglogs.org/ee34c25fe29434d9e54bbefe9b15834aefaead85cb3a1abe6ffc6f94555b7587.gz |
You meant 5.14.0. As the previous comments (e.g. #5052 (comment)) explained, it could help if you could add the IDs of some messages whose read receipts did not synchronize properly. |
Yes 🤦. I updated my post. |
This suddenly got worse for me. Now, whenever I send a message, I get push notifications on my other devices. |
You meant that you get notifications for your own messages? That doesn't seem like it's related to my original post. If it's not, can you open a new thread? |
I recently factory reset my phone, restored signal from a backup, and re-linked Signal-desktop. The problem seems to be gone now for me. |
Just happened again. All messages read on both signal-desktop instances, but not on Android signal-desktop-betahttps://debuglogs.org/f0ea312c2c3a523e7f3e98f3fdf0c80a09e961d26dcf94e23d6fb8409b207fcc.gz Sent Saturday, January 8, 2022 7:20 PM (1641666011043) signal-desktop stablehttps://debuglogs.org/4f31b4283879cdc255703e2e475a6112e8d17d2b154dfef665426406cc3cd5c6.gz Sent Saturday, January 8, 2022 7:20 PM (1641666011043) AndroidBefore opening the convohttps://debuglogs.org/7171ec8d5fd81202e4dfc89bbc7bf2002d0d47fd8e51ae88021e4a1247b32a80 After opening the convo(and seeing that the unread message was indeed the last one of the convo): (N.B.: I updated from 5.28.5 -> 5.28.10 in the meantime) |
Hi there, Android 5.29 (currently in beta) has some updated logging for read syncs that will give us some more insight. Can you give us logs from that version if it happens again? Thanks! |
Awesome, will do, thanks! |
Android (before opening the convo): https://debuglogs.org/android/5.32.14/486a090e3c7a059e38fe39552765e26911247eabd3dbf5776dd53af7d7fbc56d Message on desktop:
That happened just after I trashed my push message config on a phone where the issue hadn't happened before. It happened when I received dozens of messages at the same time when opening the app. |
@hiqua There's clear evidence that the read sync was sent for that message:
|
@greyson-signal let me know if you need more info. My FCM is fixed now (after an update that registered Signal again) so I don't have the bug anymore, but I can just unregister Signal and I expect it to happen again. |
Actually just got one more with FCM fixed and in a 1:1 discussion (and at the same time in a group discussion where I was receiving big attachments).
Android before opening the convo: |
Desktop sent the read sync:
|
Got it again. Android: https://debuglogs.org/android/5.35.3/81f91c443791d6bb1522e9c08005d43e980da0edba65a2baec68c36502745573 Sent | Today 6:38 PM (1650645480154) @greyson-signal did you ever look into the logs? I guess this bug can be moved to the Android repository. |
Looks like a bug with Android's early receipt handling. We'll look into it.
|
(honestly I'm sure there is one somewhere, I just cannot find it...)
Bug Description
State on desktop: nothing to read, up to date.
State on Android: 2 messages to read in a group (group V2). I had received these messages on Desktop. Both devices on the same (reliable) Internet connection.
I tried to restart signal desktop, but it didn't change anything. I sent messages from my Android / Desktop (from other discussions) and it was working, so no connection problem.
Steps to Reproduce
No reliable way, but:
Actual Result:
I had two messages to read in a group on Android.
Expected Result:
All messages read on Desktop should appear read on Android.
Platform Info
Signal Version:
1.40
Operating System:
Debian
Linked Device Version:
5.3.12
Link to Debug Log
Before reading the messages on Android:
desktop: https://debuglogs.org/de1d908255d5490f2d45b742e5bf1bd6b41b7b46350f50480f6f5c7b6e35c7ae
android: https://debuglogs.org/d9dae580a765d8e90faf2be2feba07796e985ec09d4a031f7d9254f89a1fa0f0
After having read the messages on Android:
desktop: https://debuglogs.org/c91dccb8784a98d828d802f9b73eab773f2e534f4d41785c9df45c2bd7d94e70
android: https://debuglogs.org/29fab26c71c9b62769c272941df108f2c68dd29d185b0fd6acf6bdbc1fe8e7bb
The text was updated successfully, but these errors were encountered: