-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
groups with unregistered users are inconsistent and display random behaviour #989
Comments
Every message an unregistered user attempts to send will fail as they are no longer a Signal user. So an alert should be on every message. This is the same behavior as the mobile clients. Is your contact in this chat the unregistered user? |
I am not talking about messages sent from unregistered users (FYI, they sometimes can send messages, see signalapp/Signal-Android#5859). In the group there are my friend and i + the unregistered dummy. The triangle is, as i have explained in this issue, is not on every message. On my signal desktop there never is a triangle (message detail view mentions the unregistered user though), while on my friend's signal-desktop there always is a triangle and 0-2 resend buttons. We are both using up-to-date versions of Signal-Desktop, and some months back i also experienced triangles and multiple resend-buttons despite no failed delivery. |
Locally remove unregistered users from group membership lists. Fixes signalapp#989 Related to signalapp/Signal-Android#6175 // FREEBIE
Locally remove unregistered users from group membership lists. Fixes signalapp#989 Related to signalapp/Signal-Android#6175 // FREEBIE
Locally remove unregistered users from group membership lists. Fixes signalapp#989 Related to signalapp/Signal-Android#6175 Closes signalapp#1052 // FREEBIE
Bug description
We have set up a group with an unregistered number to have a debugging playground for signalapp/libsignal-service-java#27. In this group are a friend and i, both with at least on Signal-Desktop instance.
My Signal-Desktop clients happily ignores the fact that we have an unregistered member. My conversation does not display any error triangles, i can only see that one delivery failed in the MessageDetailView.
His Signal-Desktop client displays an error triangle on every outgoing message that was sent from Signal-Desktop:
And sometimes it additionally display two resend buttons:
I honestly do not know what should happen if you use a group with an unregistered user, but three different possible behaviours do not look good to me.
Steps to reproduce
Platform info
Signal v0.26, i am using W10, he is using Ubuntu afaik. I have experienced this some months ago on W10, this is no platform issue.
Link to debug log
His log: http://pastebin.com/VV4F0Fex
My log: https://gist.github.com/569242ab15e4ed88e2f1f01cf8535fff
The text was updated successfully, but these errors were encountered: