Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Close Emoji Panel on Escape Key Press (Refactor) #2357

Merged
merged 2 commits into from May 8, 2018

Conversation

gasi-signal
Copy link
Contributor

Small refactor of #2354.

@gasi-signal gasi-signal merged commit f693c00 into development May 8, 2018
@gasi-signal gasi-signal deleted the emoji-panel-escape-key-close branch May 8, 2018 21:37
scottnonnenberg-signal added a commit that referenced this pull request May 10, 2018
Feature: Receive contact (#2349, #2359)

Fixed: Sometimes clicks on quoted message wouldn't work (#2350)

Fixed: In dark theme, it was hard to see a message's triple-dot menu on hover - thanks @PunkChameleon (#2334)

Fixed: Unsupported image and video types were missing from media pane (#2351)

Fixed: On small screens, the media lightbox view would show media off-screen (#2351)

Notification improvements
  - Remove all on remote read, on focus, on exit
  - Show multi-message notifications like '5 new messages'

Media Gallery: A number of small visual fixes (#2351)

Emoji pane: Can now dismiss it by pressing escape key - thanks @tommypacker (#2354, #2357)

Update translations (#2328, #2352)

Dev:
  - Windows 7: Use Electron-native notifications (#2338, #2330)
  - Improve Logging For Disappearing Messages (#2332)
  - Prettier: Continue expanding its coverage of app (#2339, #2324)
  - Document Translations Setup + Remove Unused Strings (#2329)
  - Make Protocol Buffers available to commonjs code (#2347)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants