Expire timer updates: don't send if updated via remote message #2473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A recent change removed the type property to make markRead() behave properly, but that broke our check 'should we send an update?' logic. So instead of using `isIncoming()` we now use the thing we previously used to determine whether a message was incoming: `receivedAt`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A recent change removed the
typeproperty to makemarkRead()behave properly, but that broke our 'should we send an update?' logic. So instead of usingisIncoming()we now use what we previously used to determine whether a message was incoming:receivedAt.Fixes #2472
Bug introduced here: dfa1f07#diff-e7ea6b899ac298e9faa100a737a9b5a9L885