Fix MIME check for JPEG in lightbox copy handler #4643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you update this to check for both? |
|
Let me know if 6dddde6 does the trick. I think "image/jpg" is just plain incorrect in all cases (Electron's NativeImage doesn't check for it), but I guess it couldn't hurt to handle it. |
1 task
|
Thank you! |
josh-signal
pushed a commit
that referenced
this pull request
Nov 23, 2020
* Fix MIME check for JPEG in lightbox copy handler * Handle both image/jpeg and non-standard image/jpg
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
developmentbranchyarn readyrun passes successfully (more about tests here)Description
Reference: https://www.w3.org/Graphics/JPEG/
The lightbox copy menu wasn't showing for JPEG images because #4614 was checking incorrectly for "image/jpg". I've verified that this fixes the issue in my own testing.