Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typos in ts files as per Fossies source code check #5136

Merged
merged 16 commits into from
Apr 2, 2021
Merged

Fix typos in ts files as per Fossies source code check #5136

merged 16 commits into from
Apr 2, 2021

Conversation

jost-s
Copy link
Contributor

@jost-s jost-s commented Mar 30, 2021

Contributor checklist:

Description

Fixes typos in source code files found by Fossies source code check

Evan asked me to:

  • fix all of the errors in the ts/ directory, except for exceptions.json
  • fix the one typo in stylesheets/_modules.scss. "tht" should be "the"
  • don't fix any of the errors in any of the other folders yet (ignore test/, libtextsecure/, js/, and app/)

Copy link
Contributor

@EvanHahn-Signal EvanHahn-Signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! I think this needs a rebase with development (we recently pushed some stuff) and then this is good to go.

@jost-s
Copy link
Contributor Author

jost-s commented Apr 1, 2021

Rebased (there's no way around a force-push, is there?)

Copy link
Contributor

@EvanHahn-Signal EvanHahn-Signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't think there's a way around a force push (though git push --force-with-lease is usually safe).

This looks good. Thanks for doing it!

@EvanHahn-Signal EvanHahn-Signal merged commit 9823eb2 into signalapp:development Apr 2, 2021
@jost-s jost-s deleted the bugfix/typos branch April 3, 2021 06:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

2 participants