Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix HTML ID of step for clear-data template #5229

Merged
merged 1 commit into from
May 13, 2021

Conversation

dsanders11
Copy link
Contributor

First time contributor checklist:

Contributor checklist:

Description

Fixes the HTML ID for "step 2" in background.html for the clear-data template, which was incorrectly labeled as step3. I don't believe this ID was used for anything, so it wasn't causing any problems, and I don't believe this change will affect anything. Just noticed it while exploring other code and figured it should be corrected.

@EvanHahn-Signal EvanHahn-Signal self-requested a review May 7, 2021 15:30
Copy link
Contributor

@EvanHahn-Signal EvanHahn-Signal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

We'll merge this into our internal branch soon. When we push that branch to this repository, this PR will automatically get marked as merged. No further action needed!

@josh-signal josh-signal merged commit c175c44 into signalapp:development May 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

None yet

3 participants