Focus the text input box after successfully attaching a file #6289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes signalapp#6284 - does not focus immediately (so as to avoid stealing focus) and does not focus if the file browser is cancelled.
|
Thank you! The PR will be merged with the next beta release next week. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6284 - does not focus immediately (so as to avoid stealing
focus) and does not focus if the file browser is cancelled.
First time contributor checklist:
Contributor checklist:
mainbranchyarn readyrun passes successfully (more about tests here)Description
Since there is no Send button, this makes it easier and reduces frustration when adding attachments.
Currently a user must manually click on the text input box or shift-tab to focus it and then press Enter to send.
This change automatically focuses the text input box if an attachment has been added, allowing users to just press Enter.
Manually tested on Ubuntu 22 64-bit / Gnome. No new tests since I can't find good examples of tests for
similarly small UX-related changes, though I'm happy to do so.