Double clicking emoji reaction no longer brings up replies #6301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like the Windows CI build is trying to pull from "https://github.com/electron/electron/releases/download/v22.2.0/electron-v22.2.0-win32-x64.zip:", rather than "https://github.com/electron/electron/releases/download/v22.2.0/electron-v22.2.0-win32-x64.zip", not sure how the extra colon got tossed in there as the end. |
josh-signal
approved these changes
Feb 22, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Contributor checklist:
mainbranchyarn readyrun passes successfully (more about tests here)Description
Fixes #6282, as double-clicking the reaction "box" no longer will create a draft reply. This fix simply disables the replyToMessage action if the double click takes place within the reaction reactions DOM, as if the user is double clicking in this area it is almost always with the intention of dismissing the reaction window.
Manual testing was done to ensure that this behavior not only fixed the double clicking issue within the reactions DOM, but to ensure reply functionality was not affected outside the DOM. Everything functioned as expected.
Cheers!