Fix incorrect GIF message bubble sizing #1300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TSAnimatedAdapter is used when rendering GIFs. TSAnimatedAdapter inherits from JSQMediaItem but does not provide a custom implementation of the hash method. The default implementation of hash in JSQMediaItem results in all messages of a given interaction type (incoming, outgoing) sharing a cached bubble size. For this reason, JSQMediaItem subclasses are required to implement hash (see jessesquires/JSQMessagesViewController#631). This commit fixes issue #1275 by implementing hash in TSAnimatedAdapter the same way TSPhotoAdapter does.
|
Thanks @ajstiles! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First time contributor checklist
Contributor checklist
FREEBIEin my commit messageDescription
TSAnimatedAdapter is used when rendering GIFs. TSAnimatedAdapter
inherits from JSQMediaItem but does not provide a custom implementation
of the hash method. The default implementation of hash in JSQMediaItem
results in all messages of a given interaction type (incoming,
outgoing) sharing a cached bubble size. For this reason, JSQMediaItem
subclasses are required to implement hash (see
jessesquires/JSQMessagesViewController#631).
This commit fixes #1275 by implementing hash in TSAnimatedAdapter
the same way TSPhotoAdapter does.