Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update redis to 6.2.6; support Apple Silicon #11

Closed
wants to merge 4 commits into from

Conversation

n-oden
Copy link

@n-oden n-oden commented Nov 3, 2021

  • bump the redis verions to 6.2.6
  • remove references to 32 bit macos/darwin
  • add a version of redis compiled for Apple Silicon (darwin/arm64)
  • normalize redis server file names

@n-oden
Copy link
Author

n-oden commented Nov 3, 2021

The big motivation here is redis/redis#8062 -- versions prior to 6.0.10 have a crash bug on apple silicon (even under rosetta)

@n-oden
Copy link
Author

n-oden commented Nov 3, 2021

@jon-signal @eager-signal of course I just realized after opening this that #10 updates to 6.2; I'm happy to rebase on top of that if you like.

@n-oden n-oden changed the title Update redis to 6.0.16; support Apple Silicon Update redis to 6.2.6; support Apple Silicon Nov 3, 2021
@j-maynard
Copy link

Is there any chance of adding the ARM64 binary for Linux as well? This bug affects running the embedded-redis server in Docker on the M1 Mac as well.

@n-oden
Copy link
Author

n-oden commented Nov 16, 2021

@j-maynard I'd be happy to, but I'm a little unsure at this point if this PR is even going to get merged -- it's been two weeks and there's no sign of activity here or on #10. I've actually started publishing my own fork of embedded-redis as https://search.maven.org/artifact/io.oden/embedded-redis/ for now -- can you open an issue against https://github.com/odenio/embedded-redis here and I'll try to get to it today or tomorrow?

@n-oden
Copy link
Author

n-oden commented Nov 16, 2021

@j-maynard https://s01.oss.sonatype.org/content/groups/public/io/oden/embedded-redis/0.0.3/

@eager-signal
Copy link

@n-oden thank you! This is looking good. A couple of things that we’ll need to coordinate to land it:

  1. yes, let’s rebase onto Add TLS support; update Redis to 6.2.6 #10
  2. the addition of TLS in Add TLS support; update Redis to 6.2.6 #10 makes building the Darwin binaries less straightforward, so I need to make a couple of adjustments to the instructions & scripts
  3. we’ll need to build all the embedded binaries ourselves

@n-oden
Copy link
Author

n-oden commented Nov 28, 2021

@eager-signal Awesome. Okay, so what I've done here is:

Totally understood that signal.org of all projects can't accept built binaries from randos on the internet! 🤣 What I'd suggest we do here is that you locally cherry-pick 9d0d327 into #10 and rebuild the binaries to your own satisfaction there.

- bump the redis verions to 6.2.6
- remove references to 32 bit macos/darwin
- add a version of redis compiled for Apple Silicon (darwin/arm64)
- normalize redis server file names
- add linux/arm64 support
- clean up docker/builder scripts
- update README
@n-oden
Copy link
Author

n-oden commented Dec 9, 2021

Oops, slight update: the merged commit of my changes is f7575887dec7ab3b523b6100fc612b663fa47a10

@n-oden
Copy link
Author

n-oden commented Dec 19, 2021

@eager-signal nudge? :)

@eager-signal
Copy link

nudge? :)

@n-oden 🙂 I made some updates to #12 on Friday (cherry-picked f757588, updated the build script to statically link openssl on macOS, updated binaries, updated the Java to actually use the new macOS ARM binary). I’m going to do a little more testing today, but it should all land very soon. Let me know on #12 if you have any thoughts.

@n-oden
Copy link
Author

n-oden commented Dec 21, 2021

Closing this because the action is now all over in #12 :)

@n-oden n-oden closed this Dec 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants