This repository has been archived by the owner on Feb 12, 2022. It is now read-only.
Catch & encapsulate RateLimitExceptions on send #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Repeatedly requesting prekeys for unregistered group members can lead to RateLimitExceptions, making the send job fail and leading to 4 retries. If that happens, those who precede the unregistered user in the list of group members receive the message 5 times, while the others don't receive it at all. To work around this, catch and encapsulate RateLimitExceptions and rethrow them at the end, just like with PushNetworkExceptions, UnregisteredUserExceptions, and UntrustedIdentityExceptions. Fixes signalapp/Signal-Android#6003
5 tasks
|
Made obsolete by a server change (signalapp/Signal-Android#6175 (comment)), closing. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Repeatedly requesting prekeys for unregistered group members can lead to RateLimitExceptions, making the send job fail and leading to 4 retries. If that happens, those who precede the unregistered user in the list of group members receive the message 5 times, while the others don't receive it at all.
To work around this, catch and encapsulate RateLimitExceptions and rethrow them at the end, just like with PushNetworkExceptions, UnregisteredUserExceptions, and UntrustedIdentityExceptions.
Fixes signalapp/Signal-Android#6003 (tested in an API 23 emulator)
Note: I copied the pattern of
NetworkFailureExceptionwrappingPushNetworkExceptionhere, soRateLimitExceededExceptionwrapsRateLimitException. Not sure if the name is good, but I wanted to include the recipient's number in case it's needed later.