Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude unnecessary libraries from apk #548

Closed
marinat opened this issue Dec 28, 2023 · 2 comments
Closed

Exclude unnecessary libraries from apk #548

marinat opened this issue Dec 28, 2023 · 2 comments

Comments

@marinat
Copy link

marinat commented Dec 28, 2023

When I build apk file with signal lib it contains libsignal_jni.dylib and signal_jni.dll, how to exclude them?

@jrose-signal
Copy link
Contributor

jrose-signal commented Jan 2, 2024

Oh, good catch. You can and should add them to your packagingOptions.resources.excludes, as the official Android app does here (they're in that list, you just have to scroll way out, sorry):

https://github.com/signalapp/Signal-Android/blob/e17b07bb12110c0ebeae193cb6fad35d33b57d40/app/build.gradle.kts#L148-L152

I'll leave this issue open to add that to the doc files within libsignal.

@jrose-signal
Copy link
Contributor

Readme updated in v0.38.0 with a mention of the Maven Central artifacts and the exclude options. Thanks for pointing this out!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants