-
-
Notifications
You must be signed in to change notification settings - Fork 370
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to compile v0.36.1
(JNI) - boring-sys requires git to be installed
#549
Comments
Ugh, I believe this is boring-sys spuriously wanting git to be installed (90bbc3b). I think there's a feature flag we can use now to turn that off, but v0.36 doesn't have it. Can you add git to your Docker image and see if it helps? |
Thanks @jrose-signal, that seems to have done the trick.
This seems solvable though, I believe I just need to get a more recent version of |
We probably should have called these updated build requirements out in the release notes. Let us know if you run into further issues after the protoc update! |
I edited the Dockerfile to download a pre-built |
I want to look into boring-sys a little more to see if I'm right about the purpose of that feature flag. I'll keep this issue open for that. Glad it's working now, though! |
v0.36.1
(JNI)v0.36.1
(JNI) - boring-sys requires git to be installed
Okay, so the feature flag would avoid the git dependency, but because it's a feature flag, it's not necessarily appropriate to apply it if someone wants to test out any of the other features that require patches. A more polite build script would check if there are any patches to apply, and not try to use git otherwise, but in the mean time I think editing the readme would be fine. (Which I can take care of, since it's easier to get into a subsequent release that way.) |
Readme updated in v0.38.0. Thanks for pointing this out! |
Hi,
I'm building
libsignal
in a Docker container using thejava/build_jni.sh
script. This has worked before, up until v0.32.1.However, when trying to build v0.36.1, it fails with the error below, which appears to be related to
boring-sys
:It loos like the build script can't find a required file. Any help would be greatly appreciated!
The text was updated successfully, but these errors were encountered: