Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cat broke UI by holding down space #5272

Closed
1 task done
kpcyrd opened this issue May 19, 2021 · 15 comments
Closed
1 task done

Cat broke UI by holding down space #5272

kpcyrd opened this issue May 19, 2021 · 15 comments
Labels

Comments

@kpcyrd
Copy link
Contributor

kpcyrd commented May 19, 2021

  • I have searched open and closed issues for duplicates

Bug Description

My cat sat on the keyboard holding down the space key and I noticed this breaks the UI (see attached screenshot).

Steps to Reproduce

  1. open a chat
  2. click into the "send a message" box
  3. hold down space

Actual Result:

The input field keeps growing to the right, breaking the UI

Expected Result:

Some kind of line break probably

Screenshots

2021-05-19-signal-spaces

Platform Info

Signal Version: v5.1.0

Operating System: Arch Linux

@hiqua
Copy link
Contributor

hiqua commented May 19, 2021

I can reproduce this on Debian.

To be clear, it's not really about keeping on pressing the keyboard, it's just about trying to send a message with a lot of spaces such as:

                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                                        

So copy-pasting this snippet should be enough.

I guess it's because Signal tries to soft-break the lines around word, but of course it fails for such weird messages. If it doesn't find a proper place to break the line, it should still break it after a certain limit rather than overflowing.

@ghost
Copy link

ghost commented May 23, 2021

"The kot is a QA engineer" someone said on a Discord

@RoverBot-Dev
Copy link

"The kot is a QA engineer" someone said on a Discord

helo dev khnonk

@GabLeRoux
Copy link

Steps to reproduce:

@mittwinter
Copy link

Verison 5.0.0 on Gentoo Linux is not affected, in case this helps to isolate the issue.

@adarsh1001
Copy link

Able to reproduce this bug on v5.2.1 (Ubuntu).

@SteveHere
Copy link

Verison 5.0.0 on Gentoo Linux is not affected, in case this helps to isolate the issue.

This seems to involve a problem with Debian; Might need someone not on a Debian-based system to reproduce this result. 😕

@rizerphe
Copy link

rizerphe commented May 24, 2021

OP is using arch ¯\(ツ)

@AmadeusMop
Copy link

AmadeusMop commented May 24, 2021

Able to reproduce this bug on v5.2.1, Windows 10 19042.985, gray domestic mediumhair.
Also tried with the tortoiseshell, but could not reproduce because she wouldn't sit still.

@techhotspot
Copy link

Dogs work, can reproduce, 22.5 pound English cocker though apparently my keyboard doesn’t taste good

@alex-moch
Copy link

Verison 5.0.0 on Gentoo Linux is not affected, in case this helps to isolate the issue.

I can verify that version 5.0.0 on Gentoo Linux is not affected. However, I can reproduce the issue with version 5.2.1.

@00p513-dev
Copy link

5.2.1 on fedora affected. Tested with a Shih Tzu, 24 cm, 3.5 kg and a Shiba Inu, 8kg, 40cm

@gunslingerfry
Copy link

gunslingerfry commented May 25, 2021

Confirmed bug with bug on beta 5.3.0-beta.2
Running: Manjaro Ornara 21.0.5

Can also confirm bug does not repro bug on 5.0 or the older version of the beta that was labeled 1.39.5-beta1-3
PXL_20210525_015904262

@robinduerhager
Copy link

I cannot reproduce this issue on Windows 10 Pro Version 21H1 Build 19043.1348.
However, it breaks the flow of the stickers, microphone and plus icons for me 😅 .

sendmessage-icon-flow-break

@kpcyrd
Copy link
Contributor Author

kpcyrd commented Nov 14, 2021

Closing, the original issues seems to be fixed. Thanks for the ping!

@kpcyrd kpcyrd closed this as completed Nov 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Development

No branches or pull requests