make env package functions return copies of their pointed default values #141
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think there is benefit to keeping the default argument as a pointer. Specifically in the gateway, where we are passing in a pointer to a loaded config value which may or may not be nil.
I do think that these functions shouldn't blindly return the default argument as is. Instead they should return a pointer to a copy of the default argument's value. Hopefully this will help reduce confusion since the functions are returning pointers to values, instead of setting the value at a specified pointer.