add TooManyRequestError to sfxclient #179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return t.Sub(time.Now()), nil | ||
| } | ||
|
|
||
| // Retry-After: <delay-seconds> |
There was a problem hiding this comment.
It looks like this form is the only one we emit, not the (above, and likely correct) HTTP 1.1 date.
There was a problem hiding this comment.
(just a note, that you included the date parse above is nice of you!)
cory-signalfx
approved these changes
Apr 17, 2020
|
This patch will allow the client to discern a 429, but it does not adjust the behavior of the sink to honor the |
|
@cory-signalfx thanks for the quick review 😄 unfortunately it breaks the build:
I'll read the build script and make sure it's green before submitting another PR to fix that. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some information from SignalFx could be used to help the client to decide what to do on failure:
429 is only returned by the ingestion data points when a limit has been reached of metrics or event rates.
There is a Throttle-Type header returned with the 429 which indicates what the reason was for the 429 to be returned.
There is a Retry-After header returned with the 429 which indicates the backoff time which should be used.