Fix conversion bug for annotations to sapm logs, when not JSON #199
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply same logic as in the ingest-protocols repository in the "v2AnnotationsToJaegerLogs" function. That needs now to be updated and not check for error. Signed-off-by: Bogdan Drutu <bogdandrutu@gmail.com>
bogdandrutu
force-pushed
the
sapmlogs
branch
from
83661e8
to
4fc3211
Compare
|
@mdubbyap after you merge this, can you please do a new release? |
mdubbyap
approved these changes
Sep 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apply same logic as in the ingest-protocols repository in the "v2AnnotationsToJaegerLogs" function. That needs now to be updated and not check for error.
Signed-off-by: Bogdan Drutu bogdandrutu@gmail.com