fix test cases #211
Merged
fix test cases #211
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keitwb
reviewed
Dec 16, 2020
keitwb
approved these changes
Dec 16, 2020
package golib/sfxclient currently is taking close to 30s for running all test cases. This fix will reduce the testing time to ~4s. Other packages have minor tune ups reducing testing time in order of milliseconds. There is no test case for golib/trace/format as it is auto-generated code and golib/logkey as it contains only global variables. So removing both the packages from go list output in travis.yml file. golib doesn't use t.Parallel in any of the test suites and hence -parallel flag is removed from go test arguments list
jgheewala
force-pushed
the
fix_it_speedup_test_cases
branch
from
b9e4e19
to
581c166
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
package golib/sfxclient currently is taking close to 30s for running
all test cases. This fix will reduce the testing time to ~4s.
Other packages have minor tune ups reducing testing time in order of
milliseconds.
There is no test case for golib/trace/format as it is auto-generated code
and golib/logkey as it contains only global variables. So removing both the
packages from go list output in travis.yml file.
golib doesn't use t.Parallel in any of the test suites and hence -parallel flag
is removed from go test arguments list