New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use static 404 for unsupported signalfx-forwarder paths #1731
Conversation
ee56683
to
6bfde65
Compare
pkg/monitors/forwarder/forwarder.go
Outdated
_, _ = w.Write([]byte(errMsg + "\n")) | ||
errMsg := "Datapoint or span request received on invalid path" | ||
logger.ThrottledError(fmt.Sprintf("%s: %s", errMsg, r.URL.Path)) | ||
errMsg = fmt.Sprintf("%s. You should send to the same path that you would on the Smart Gateway.\n", errMsg) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actually this is an obsolete message since we don't really use Gateway anymore. This ideally would just be a list of the supported paths for maximum clarity.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated w/ supported paths.
6bfde65
to
b0ac5e4
Compare
Deprecation Notice: * SA deprecation notice for April 15 GA (#1720) * Pull deprecation notice to integrations repo (#1721) Changes: * prometheus-exporter monitor: Don't set timestamp (#1703) * Update ingest-protocols lib (#1704) * sfxcollectd: Fix single item handling with #flatten (#1705) * Allow non defined in collectd/jenkins metrics (#1706) * writer: Sanitize token in HTTP error logs (#1710) * excludeJobMetrics parameter available on collectd-jenkins v2.4.0 (#1712) + Update scripts, docs, and CI for main (#1724) * Add an option to control remote config watch (#1730) * Security updates for third-party dependencies Breaking Changes: * Use static 404 for unsupported signalfx-forwarder paths instead of 200 (#1731)
Deprecation Notice: * SA deprecation notice for April 15 GA (#1720) * Pull deprecation notice to integrations repo (#1721) Changes: * prometheus-exporter monitor: Don't set timestamp (#1703) * Update ingest-protocols lib (#1704) * sfxcollectd: Fix single item handling with #flatten (#1705) * Allow non defined in collectd/jenkins metrics (#1706) * writer: Sanitize token in HTTP error logs (#1710) * excludeJobMetrics parameter available on collectd-jenkins v2.4.0 (#1712) * Update scripts, docs, and CI for main (#1724) * Add an option to control remote config watch (#1730) * Security updates for third-party dependencies Breaking Changes: * Use static 404 for unsupported signalfx-forwarder paths instead of 200 (#1731)
Deprecation Notice: * SA deprecation notice for April 15 GA (#1720) * Pull deprecation notice to integrations repo (#1721) Changes: * prometheus-exporter monitor: Don't set timestamp (#1703) * Update ingest-protocols lib (#1704) * sfxcollectd: Fix single item handling with #flatten (#1705) * Allow non defined in collectd/jenkins metrics (#1706) * writer: Sanitize token in HTTP error logs (#1710) * excludeJobMetrics parameter available on collectd-jenkins v2.4.0 (#1712) * Update scripts, docs, and CI for main (#1724) * Add an option to control remote config watch (#1730) * Security updates for third-party dependencies Breaking Changes: * Use static 404 for unsupported signalfx-forwarder paths instead of 200 (#1731)
Instead of returning 200 with dynamic message echoing potentially undesired/unsanitized content, the signalfx-forwarder monitor should return generic 404.