writer: new option to log rejected spans #1922
Conversation
jtmal-signalfx
requested review from
asuresh4,
jeffreyc-splunk,
keitwb,
mstumpfx,
rmfitzpatrick and
a team
as code owners
| }).Error("Error shipping spans to SignalFx") | ||
| var meta log.Fields | ||
| if sw.conf.LogTraceSpansFailedToShip { | ||
| jsonEncodedSpans, _ := json.Marshal(spans) |
There was a problem hiding this comment.
err should be checked or this can panic. Also if we failed to ship them it is possible json.Marshal could fail as well.
There was a problem hiding this comment.
I think jsonEncodedSpans would be nil if there were an err so payload below would just show nil. A json marshal error is pretty hard to imagine though since we aren't using generic data structures in the spans, just a well-defined span format that we know serializes fine.
pkg/core/writer/signalfx/spans.go
Outdated
| jsonEncodedSpans, _ := json.Marshal(spans) | ||
| meta = log.Fields{ | ||
| "error": err, | ||
| "payload": jsonEncodedSpans, |
There was a problem hiding this comment.
I assume this case will be enabled for debugging purposes only so it is OK to log entire batches?
There was a problem hiding this comment.
yes, this option is only to be enabled when investigating tooManySpansInTrace as the backend gets rid of these
docs/config-schema.md
Outdated
| @@ -154,6 +154,7 @@ The **nested** `writer` config object has the following fields: | |||
| | `logDatapoints` | no | bool | If the log level is set to `debug` and this is true, all datapoints generated by the agent will be logged. (**default:** `false`) | | |||
| | `logEvents` | no | bool | The analogue of `logDatapoints` for events. (**default:** `false`) | | |||
| | `logTraceSpans` | no | bool | The analogue of `logDatapoints` for trace spans. (**default:** `false`) | | |||
| | `LogTraceSpansFailedToShip` | no | bool | If `true`, traces and spans which weren't successfully received by the backend, will be logged as json. (**default:** `false`) | | |||
There was a problem hiding this comment.
You have to run make docs in a linux env to properly generate this, not manually edited.
|
@jtmal-signalfx see if you can figure out what is messing with the spaces in the docs that is causing the docs_test to fail. It might be that your editor is doing formatting on it unintentionally. |
No description provided.