Split out signalflow into separate module #332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Comment on lines
+63
to
+66
| <dependency> | ||
| <groupId>org.apache.httpcomponents</groupId> | ||
| <artifactId>httpclient</artifactId> | ||
| </dependency> |
There was a problem hiding this comment.
That's defined as a compile dependency in the parent pom
There was a problem hiding this comment.
I think the parent just sets up the versions...so this is definitely required, I confirmed that removing it breaks the build.
There was a problem hiding this comment.
I think the parent just sets up the versions...so this is definitely required, I confirmed that removing it breaks the build.
I'm not saying that it's not required; I'm saying that if it's a test dep it needs <scope>test</scope>
There was a problem hiding this comment.
Yeah, that doesn't work because it's used by the RetryStrategy and RetryHandler which are production classes.
Co-authored-by: Mateusz Rzeszutek <mrzeszutek@splunk.com>
|
ready for another look @mateuszrzeszutek thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This modularizes the code quite a bit. There are some tangled dependencies, so 2 additional modules also needed to be factored out:
signalfx-connectionandsignalfx-endpoint.The dependency graph is basically:
graph TD; signalfx-connection-->signalfx-endpoint; signalfx-signalflow-->signalfx-endpoint; signalfx-signalflow-->signalfx-connection; signalfx-java-->signalfx-connection; signalfx-java-->signalfx-endpoint; signalfx-java-->signalfx-signalflow;There was one code change needed to eliminate cycles there. The
SignalFxMetricsExceptionwhich was an unnecessary (named/tag) subclass ofRuntimeExceptionwas replaced with justRuntimeException.While I do think this split helps to better organize and show where dependencies are and to eventually pull out signalflow, it also highlights that signalflow still has some dependencies on this common stuff.