Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adjust configuration for istio environment #171

Merged
merged 1 commit into from
Jul 7, 2021
Merged

Adjust configuration for istio environment #171

merged 1 commit into from
Jul 7, 2021

Conversation

dmitryax
Copy link
Contributor

@dmitryax dmitryax commented Jul 7, 2021

Add new config option autodetect.istio, which, if enabled, adds few things to the default configuration:

  • Add service.name attribute to logs that are composed the same way as done for traces in istio. This enables APM <-> Log Observer correlation OOTB.
  • Add automatic istio metrics scraping that are exposed via prometheus endpoints.
  • Add sidecar.istio.io/inject: "false" annotation to the otel-collector pods to avoid infinite self-tracing.

@dmitryax dmitryax requested review from a team as code owners July 7, 2021 22:49
Add new config option autodetect.istio, which, if enabled, adds few things to the default configuration:
- Add `service.name` attribute to logs that are composed the same way as done for traces in istio. This enables APM <-> Log Observer correlation OOTB.
- Add automatic istio metrics scraping that are exposed via prometheus endpoints.
- Add `sidecar.istio.io/inject: "false"` annotation to the otel-collector pods to avoid infinite self-tracing.
Copy link
Contributor

@flands flands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- I am not sure disabling Istio injection will work for all environments, but likely good enough for now. We should document what these settings do better.

@dmitryax dmitryax merged commit 3dca47e into main Jul 7, 2021
@dmitryax dmitryax deleted the istio branch July 8, 2021 00:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants