Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating schema validation for imagePullSecrets as expected by chart #356

Merged
merged 1 commit into from Jan 13, 2022

Conversation

nitaliya
Copy link
Contributor

Updated chart validation schema for imagePullSecrets to sync with the expectation of the chart
Previously expected validation by the schema is as mentioned below but the chart expects string instead of object type:

imagePullSecrets:
  - name: myregistry

Expected by the chart:

imagePullSecrets:
  - myregistry

@nitaliya nitaliya requested review from a team as code owners January 13, 2022 05:44
Copy link
Contributor

@dmitryax dmitryax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing this!

@dmitryax dmitryax merged commit 785ce65 into signalfx:main Jan 13, 2022
@nitaliya nitaliya deleted the imagePullSecrets-validations branch January 13, 2022 10:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants