Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Smart Agent log receiver #161

Merged
merged 2 commits into from
Mar 12, 2021
Merged

Smart Agent log receiver #161

merged 2 commits into from
Mar 12, 2021

Conversation

rmfitzpatrick
Copy link
Contributor

(In lieu of #149)

These changes allow the Smart Agent receiver to act as both a metrics and logs receiver, as well as removing the notion of an event client in config and Output functionality. Instead they use standard log pipelines after I discovered that the main user of events in the agent, the processlist monitor, requires a host dimension that must be added via processor in a log pipeline unless hardcoded in agent config (open-telemetry/opentelemetry-collector-contrib#2631 is necessary in SFx exporter for this to take effect).

Also includes the basic SFx exporter dimension client defaulting logic, which is simpler without event clients.

@codecov
Copy link

codecov bot commented Mar 11, 2021

Codecov Report

Merging #161 (130b5d3) into main (ed2f46c) will decrease coverage by 0.32%.
The diff coverage is 95.89%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #161      +/-   ##
==========================================
- Coverage   88.94%   88.62%   -0.33%     
==========================================
  Files          16       16              
  Lines         932      958      +26     
==========================================
+ Hits          829      849      +20     
- Misses         73       76       +3     
- Partials       30       33       +3     
Impacted Files Coverage Δ
internal/receiver/smartagentreceiver/config.go 93.47% <ø> (-0.21%) ⬇️
internal/receiver/smartagentreceiver/output.go 92.15% <93.02%> (-5.76%) ⬇️
internal/receiver/smartagentreceiver/factory.go 100.00% <100.00%> (ø)
internal/receiver/smartagentreceiver/receiver.go 90.72% <100.00%> (+0.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ed2f46c...130b5d3. Read the comment docs.

internal/receiver/smartagentreceiver/README.md Outdated Show resolved Hide resolved
Comment on lines +70 to +67
logs:
receivers: [smartagent/processlist]
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, just to clarify. The logs pipeline is required for events to work, correct?
Do we want to document which monitors require it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, it's required and I will provide a list of dimension update and event using monitors w/ my next full documentation PR.

@rmfitzpatrick rmfitzpatrick merged commit 9c118f2 into main Mar 12, 2021
@delete-merged-branch delete-merged-branch bot deleted the smartagent_log_receiver branch March 12, 2021 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants