Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Trace support to SA Receiver #192

Merged
merged 2 commits into from
Mar 23, 2021
Merged

Add Trace support to SA Receiver #192

merged 2 commits into from
Mar 23, 2021

Conversation

rmfitzpatrick
Copy link
Contributor

These changes adopt the converter introduced in #178 and add trace receiver support to the Smart Agent Receiver. They also port the extra and default span tags functionality from the SA codebase.

This is largely done to support the signalfx-forwarder monitor, whose documentation I will add in a subsequent PR once #167 has landed.

@codecov
Copy link

codecov bot commented Mar 22, 2021

Codecov Report

Merging #192 (d78a1c1) into main (a1c52ac) will increase coverage by 0.30%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #192      +/-   ##
==========================================
+ Coverage   88.58%   88.88%   +0.30%     
==========================================
  Files          18       18              
  Lines         981     1008      +27     
==========================================
+ Hits          869      896      +27     
  Misses         78       78              
  Partials       34       34              
Impacted Files Coverage Δ
internal/receiver/smartagentreceiver/factory.go 100.00% <100.00%> (ø)
internal/receiver/smartagentreceiver/output.go 93.16% <100.00%> (+1.00%) ⬆️
internal/receiver/smartagentreceiver/receiver.go 91.17% <100.00%> (+0.45%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a1c52ac...d78a1c1. Read the comment docs.

Copy link
Contributor

@pmcollins pmcollins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmfitzpatrick rmfitzpatrick merged commit 21dd4db into main Mar 23, 2021
@delete-merged-branch delete-merged-branch bot deleted the sa_trace_receiver branch March 23, 2021 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants