Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove some exports from the smartagent receiver #2077

Merged
merged 2 commits into from Oct 5, 2022

Conversation

atoulme
Copy link
Contributor

@atoulme atoulme commented Oct 5, 2022

Unexport all types that can be made package private for the smart agent receiver.
This is a change that should not affect any logic in the code.

@atoulme atoulme requested review from a team as code owners October 5, 2022 00:20
@atoulme atoulme force-pushed the do_not_export_signalfx_types branch from 55a7fa1 to 5be5f83 Compare October 5, 2022 16:32
@atoulme atoulme force-pushed the do_not_export_signalfx_types branch from 5be5f83 to 05f5ffc Compare October 5, 2022 16:52
@atoulme
Copy link
Contributor Author

atoulme commented Oct 5, 2022

Not sure why checks don't run.

@atoulme atoulme merged commit 3f6e6e9 into main Oct 5, 2022
@delete-merged-branch delete-merged-branch bot deleted the do_not_export_signalfx_types branch October 5, 2022 18:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants