Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Linux support bundle script #208

Merged
merged 7 commits into from
Apr 1, 2021
Merged

Add Linux support bundle script #208

merged 7 commits into from
Apr 1, 2021

Conversation

flands
Copy link
Contributor

@flands flands commented Mar 29, 2021

  • Update troubleshooting guide with support case details
  • Move upstream troubleshooting from README.md to troubleshooting.md
  • Add tests to existing installer_test

- Ensure executable
- Update troubleshooting guide with support case details
- Move upstream troubleshooting from README.md to troubleshooting.md
- Add tests to existing installer_test
docs/troubleshooting.md Outdated Show resolved Hide resolved
docs/troubleshooting.md Show resolved Hide resolved
#######################################
CONFDIR="/etc/otel/collector" # Default configuration directory
DIRECTORY= # Either passed as CLI parameter or later set to CONFDIR
TMPDIR="/tmp/splunk-support-bundle-$(date +%s)" # Unique temporary directory for support bundle contents
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wonder if it's preferable to use mktemp for staging and then produce the support tarball in the directory where the command is invoked by default w/ configurable --output.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought about this but feared compatibility across systems (not POSIX to my knowledge). Given installer script relies on /tmp already this felt "safe", but open to change this. @jchengsfx thoughts here?

flands and others added 2 commits March 30, 2021 14:31
Co-authored-by: Ryan Fitzpatrick <rmfitzpatrick@users.noreply.github.com>
Co-authored-by: Ryan Fitzpatrick <rmfitzpatrick@users.noreply.github.com>
docs/troubleshooting.md Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Mar 30, 2021

Codecov Report

Merging #208 (fec1252) into main (8a52d52) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #208   +/-   ##
=======================================
  Coverage   89.10%   89.10%           
=======================================
  Files          18       18           
  Lines        1010     1010           
=======================================
  Hits          900      900           
  Misses         77       77           
  Partials       33       33           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8a52d52...fec1252. Read the comment docs.

@flands flands marked this pull request as ready for review March 30, 2021 23:09
@flands flands merged commit c3dbe9a into main Apr 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the flands/support-bundle branch April 1, 2021 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants