Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include SA bundle in msi #222

Merged
merged 2 commits into from
Apr 1, 2021
Merged

Include SA bundle in msi #222

merged 2 commits into from
Apr 1, 2021

Conversation

rmfitzpatrick
Copy link
Contributor

requires #210

These changes add a slightly modified Smart Agent bundle to msi installations. There is a path length limitation w/ WiX and Wine that prevents copying it completely that I wasn't able to find a workaround to while preserving signed builds in linux.

Copy link
Contributor

@flands flands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmfitzpatrick rmfitzpatrick force-pushed the msi_builder branch 2 times, most recently from 00f51a0 to 908f791 Compare March 31, 2021 15:25
@delete-merged-branch delete-merged-branch bot deleted the branch main March 31, 2021 19:39
@rmfitzpatrick rmfitzpatrick changed the base branch from msi_builder to main March 31, 2021 19:43
Copy link
Contributor

@flands flands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rmfitzpatrick rmfitzpatrick merged commit 6467337 into main Apr 1, 2021
@delete-merged-branch delete-merged-branch bot deleted the sa_bundle_msi branch April 1, 2021 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants