Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't override system resource attrs in default config #239

Merged
merged 1 commit into from
Apr 6, 2021

Conversation

rmfitzpatrick
Copy link
Contributor

Any host.name and os.type resource attributes that have been set should be respected instead of overridden by our provided resource detection processor instance. Otherwise there is the potential for masking the actual data source.

@codecov
Copy link

codecov bot commented Apr 5, 2021

Codecov Report

Merging #239 (60b0c50) into main (0ef8ec7) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #239   +/-   ##
=======================================
  Coverage   89.01%   89.01%           
=======================================
  Files          18       18           
  Lines        1020     1020           
=======================================
  Hits          908      908           
  Misses         78       78           
  Partials       34       34           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0ef8ec7...60b0c50. Read the comment docs.

@rmfitzpatrick rmfitzpatrick merged commit 32e3488 into main Apr 6, 2021
@delete-merged-branch delete-merged-branch bot deleted the agent_cfg_rdp_dont_override branch April 6, 2021 13:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants