zero config: add disable svcname generation capability #2410
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change also adds a generate_svc_name config param.
This change also adds a generate_svc_name config param.
setting service name can be disabled by setting generate_service_name=false in the config file. in a later release service name generation will be disabled by default.
pmcollins
force-pushed
the
zc-java-disable-svcname
branch
from
e77a776
to
757a1dc
Compare
pmcollins
commented
Dec 22, 2022
| return v != NULL && !streq("false", v) && !streq("FALSE", v) && !streq("0", v); | ||
| } | ||
|
|
||
| bool str_eq_false(char *v) { |
There was a problem hiding this comment.
I'm going to consolidate these two functions into str_to_bool(char *v, bool default) in a separate PR.
atoulme
approved these changes
Dec 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Service name generation can now be disabled by setting
generate_service_name=falseinthe config file. In a later release, service name generation will be disabled by
default.