Tanzu Tile implementation and documentation #2726
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
crobert-1
force-pushed
the
tanzu_tile_dev
branch
from
72cb883
to
dfbc5e2
Compare
aurbiztondo-splunk
approved these changes
Mar 16, 2023
This change implements the required code for creating the Tanzu Tile. The Tanzu Tile is a way to deploy the collector to get metrics from the Tanzu environment. In the tile directory, run the command ./make-latest-tile to generate the Tanzu tile. Refer to DEVELOPMENT.md to know how to properly use the created tile.
New action tests tile creation to make sure changes to the BOSH releaes and Tanzu tile don't break making the tile. Also, fix BOSH release test link to homebrew.
There is no need to download and have the Smart Agent as a dependency for the bosh release and tanzu tile, so this removes it.
- Add makefile for BOSH deployment effort - Add more links for BOSH development info - Clear up confusion with READMEs
I got in contact with Josh Johnson, a product designer for Splunk o11y, and he provided the Splunk logo that is broadly used in o11y.
- Should be splunk-otel-collector rather than splunk-opentelemetry-collector
crobert-1
force-pushed
the
tanzu_tile_dev
branch
from
c5a86e4
to
1150615
Compare
pmcollins
approved these changes
Mar 23, 2023
atoulme
reviewed
Mar 24, 2023
atoulme
reviewed
Mar 24, 2023
atoulme
reviewed
Mar 24, 2023
atoulme
reviewed
Mar 24, 2023
- Add OpenTelemetry to Splunk Collector references - Make shallow clone in setup script - Set homebrew action to specific commit
There was a problem hiding this comment.
We should add our license where applicable (scripts, Makefile, etc):
# Copyright Splunk Inc.
#
# Licensed under the Apache License, Version 2.0 (the "License");
# you may not use this file except in compliance with the License.
# You may obtain a copy of the License at
#
# http://www.apache.org/licenses/LICENSE-2.0
#
# Unless required by applicable law or agreed to in writing, software
# distributed under the License is distributed on an "AS IS" BASIS,
# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
# See the License for the specific language governing permissions and
# limitations under the License.
I've added the license header to a the scripts and makefiles that I thought were relevant, but please let me know if I missed any. I'm not sure exactly which files require the header. |
jeffreyc-splunk
approved these changes
Mar 24, 2023
When the variable name is alone it's interpreted as a command, rather than setting the variable.
rmfitzpatrick
approved these changes
Mar 28, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change implements the required code for creating the Tanzu Tile. The Tanzu Tile is a way to deploy the collector to get metrics from the Tanzu environment. In the tile directory, run the command
deployments/cloudfoundry/tile/make-latest-tileto generate the Tanzu tile. Refer todeployments/cloudfoundry/tile/DEVELOPMENT.mdto know how to properly use the created tile.