Added etcd2 config source #317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owais
force-pushed
the
etcd2-config-source
branch
2 times, most recently
from
ef27f73
to
15004ab
Compare
Codecov Report
@@ Coverage Diff @@
## main #317 +/- ##
==========================================
+ Coverage 79.10% 79.51% +0.40%
==========================================
Files 30 33 +3
Lines 2240 2328 +88
==========================================
+ Hits 1772 1851 +79
- Misses 423 431 +8
- Partials 45 46 +1
Continue to review full report at Codecov.
|
pjanotti
approved these changes
Apr 22, 2021
|
A good thing to add will be a README.md describing the config options and a few examples, nothing fancy: configuration information and examples, see https://github.com/signalfx/splunk-otel-collector/blob/main/internal/configsource/vaultconfigsource/README.md |
owais
force-pushed
the
etcd2-config-source
branch
2 times, most recently
from
d67572e
to
d6a7968
Compare
owais
force-pushed
the
etcd2-config-source
branch
from
d6a7968
to
acdbc54
Compare
pjanotti
approved these changes
Apr 22, 2021
| endpoints: [http://localhost:2379] | ||
| # auth is a optional section used to indicate the authentication method to be used. | ||
| # currently only username and password is supported. | ||
| auth: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.