Fix config parsing for structs and pointers to structs #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asuresh4
commented
Apr 28, 2021
| allSettings[updatedKey] = val | ||
| } | ||
| } | ||
| recursivelyCapitalizeConfigKeys(allSettings, yamlTags) |
There was a problem hiding this comment.
I believe this should fix the issue reported in #322, not being able to set authType in kubelet.APIConfig.
| @@ -131,6 +125,19 @@ func (cfg *Config) Unmarshal(componentParser *config.Parser) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func recursivelyCapitalizeConfigKeys(settings map[string]interface{}, yamlTags map[string]string) { | |||
There was a problem hiding this comment.
Since this is a viper-centric issue I wonder if yamlTagsFromStruct and recursivelyCapitalizeConfigKeys should be in a parent function (or receiver method)* like respectYamlTagsInAllSettings()
There was a problem hiding this comment.
@rmfitzpatrick - I've moved these methods to a helper and exposed RespectYamlTagsInAllSettings which can be used by both the receiver and the extension. Let me know if you think it's better.
asuresh4
force-pushed
the
fix-config-parsing
branch
from
fe9145f
to
a1b2966
Compare
pjanotti
referenced
this pull request
in pjanotti/splunk-otel-collector
May 4, 2021
* Fix config parsing for structs * Move common config utils to helper
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses the following -