removed agent/status #3678
Merged
removed agent/status #3678
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atoulme
approved these changes
Sep 20, 2023
samiura
force-pushed
the
removed-statu-and-agent
branch
from
9bd3bde
to
2b94869
Compare
jvoravong
approved these changes
Sep 21, 2023
| "github.com/signalfx/signalfx-agent/pkg/utils" | ||
| ) | ||
|
|
||
| //go:generate sh -c "test -e `go env GOPATH`/bin/genny > /dev/null || (cd ../.. && go install github.com/mauricelam/genny)" |
There was a problem hiding this comment.
This is where genny is installed, which is expected by the splunk writer and causing the failed test* job. It can be relocated there, or I suspect that writer code can be removed since I don't believe it's exercised.
There was a problem hiding this comment.
@rmfitzpatrick thank you so much. I was tearing my head apart. Let me remove writer code and run tests to make sure everything is sane.
samiura
force-pushed
the
removed-statu-and-agent
branch
2 times, most recently
from
fd0e957
to
15b676b
Compare
samiura
force-pushed
the
removed-statu-and-agent
branch
from
15b676b
to
d432654
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Removing dead code incrementally
Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing:
Documentation: