Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add debian 12 support to installer #3766

Merged
merged 1 commit into from Oct 16, 2023
Merged

Add debian 12 support to installer #3766

merged 1 commit into from Oct 16, 2023

Conversation

rmfitzpatrick
Copy link
Contributor

Description:
These changes add debian 12 to the installer allowlist and packaging tests.

@rmfitzpatrick rmfitzpatrick requested review from a team as code owners October 12, 2023 20:46
@jeffreyc-splunk
Copy link
Contributor

https://github.com/signalfx/splunk-otel-collector/blob/main/internal/buildscripts/packaging/installer/install.sh#L96

Should we try upgrading fluentd to v5 specifically for bookworm since there are no v4 packages?

@rmfitzpatrick
Copy link
Contributor Author

rmfitzpatrick commented Oct 12, 2023

Should we try upgrading fluentd to v5 specifically for bookworm since there are no v4 packages?

I was about to ask you :). This would increase the scope of these changes to include vetting the existing fluentd config on v5. Anything else you can think* of?

@rmfitzpatrick
Copy link
Contributor Author

Maybe it's best to disallow fluentd at first and then adopt v5 for https://td-agent-package-browser.herokuapp.com/lts/5/amazon/2023 as well in subsequent changes.

@jeffreyc-splunk
Copy link
Contributor

Maybe it's best to disallow fluentd at first and then adopt v5 for https://td-agent-package-browser.herokuapp.com/lts/5/amazon/2023 as well in subsequent changes.

Probably. You'll need to update https://github.com/signalfx/splunk-otel-collector/blob/main/internal/buildscripts/packaging/installer/install.sh#L797 and https://github.com/signalfx/splunk-otel-collector/blob/main/internal/buildscripts/packaging/tests/installer_test.py#L149.

Copy link
Contributor

@jeffreyc-splunk jeffreyc-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! We'll need to update the changelog, product docs, and the o11y integration wizard whenever this is released.

@rmfitzpatrick rmfitzpatrick merged commit 2df3f4c into main Oct 16, 2023
91 checks passed
@delete-merged-branch delete-merged-branch bot deleted the bookworm branch October 16, 2023 18:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants