-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add splunk_otlp_histograms resource attr #4655
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjanotti
reviewed
Apr 11, 2024
pjanotti
reviewed
Apr 11, 2024
c41b113
to
31dc17b
Compare
dmitryax
reviewed
Apr 11, 2024
dmitryax
approved these changes
Apr 11, 2024
@jinja2 From an end-user perspective, enabling histograms in SFx exporter would still be the same? Is this transparent to the end users configuring the Collector for histogram export? |
pjanotti
approved these changes
Apr 11, 2024
@theletterf yes, this change is transparent to the user. We want to use this attribute to track usage of the feature on our end. |
Co-authored-by: Dmitrii Anoshin <anoshindx@gmail.com>
84bf74f
to
32f9166
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Adds the resource attribute
splunk_otlp_histograms: true
to theservice::telemetry::resource
if the collector detects any in use signalfx metrics exporter with the flagsend_otlp_histograms
enabled.Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>
Testing:
Added tests
Documentation: