Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add splunk_otlp_histograms resource attr #4655

Merged
merged 4 commits into from
Apr 11, 2024
Merged

add splunk_otlp_histograms resource attr #4655

merged 4 commits into from
Apr 11, 2024

Conversation

jinja2
Copy link
Contributor

@jinja2 jinja2 commented Apr 11, 2024

Description:

Adds the resource attribute splunk_otlp_histograms: true to the service::telemetry::resource if the collector detects any in use signalfx metrics exporter with the flag send_otlp_histograms enabled.

Link to Splunk idea: <Link to Splunk idea, see https://ideas.splunk.com>

Testing:
Added tests

Documentation:

internal/configconverter/otlp_histogram_attr.go Outdated Show resolved Hide resolved
internal/configconverter/otlp_histogram_attr.go Outdated Show resolved Hide resolved
internal/configconverter/otlp_histogram_attr.go Outdated Show resolved Hide resolved
internal/configconverter/otlp_histogram_attr_test.go Outdated Show resolved Hide resolved
@jinja2 jinja2 marked this pull request as ready for review April 11, 2024 06:13
@jinja2 jinja2 requested review from a team as code owners April 11, 2024 06:13
@theletterf
Copy link
Member

@jinja2 From an end-user perspective, enabling histograms in SFx exporter would still be the same? Is this transparent to the end users configuring the Collector for histogram export?

@jinja2
Copy link
Contributor Author

jinja2 commented Apr 11, 2024

@theletterf yes, this change is transparent to the user. We want to use this attribute to track usage of the feature on our end.

@jinja2 jinja2 merged commit 11cb205 into main Apr 11, 2024
27 checks passed
@jinja2 jinja2 deleted the add-otlp-histo-attr branch April 11, 2024 17:47
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants