[receiver/discovery] Update entity events ID fields #4739
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dmitryax
force-pushed
the
update-entity-events-model
branch
from
f6b12bd
to
36f5e80
Compare
samiura
reviewed
Apr 26, 2024
| } | ||
| return entityEvents, failed, err | ||
| } | ||
|
|
||
| func entityDeleteEvents(endpoints []observer.Endpoint, ts time.Time) experimentalmetricmetadata.EntityEventsSlice { | ||
| func entityDeleteEvents(endpoints []observer.Endpoint, ts time.Time) (ees experimentalmetricmetadata.EntityEventsSlice, failed int, err error) { |
There was a problem hiding this comment.
Why we need the failed (int) value? Is it a return code?
There was a problem hiding this comment.
This is just for logging. We do the same for emitEntityStateEvents, so I kept it the same, but I agree it's not ideal. We can probably move the logging inside the funcs. I can address it separately
samiura
approved these changes
Apr 26, 2024
dmitryax
force-pushed
the
update-entity-events-model
branch
from
36f5e80
to
80ff86c
Compare
|
Test failures are unrelated and fixed in #4740 |
Update entity events ID fields according to the latest contract with the inventory service: - `discovery.endpoint.id` is moved from identifying to regular attributes - The following attributes now marked as identifying instead: - `k8s.pod.uid` - `k8s.node.uid` - `container.id` - `source.port` - `host.id`
dmitryax
force-pushed
the
update-entity-events-model
branch
from
80ff86c
to
4f0f7fa
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update entity events ID fields according to the latest contract with the inventory service:
discovery.endpoint.idis moved from identifying to regular attributesk8s.pod.uidk8s.node.uidcontainer.idsource.porthost.id