Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Rabbitmq receiver to the Splunk distribution of Otel Collector. #4980

Merged
merged 3 commits into from
Jun 17, 2024

Conversation

samiura
Copy link
Contributor

@samiura samiura commented Jun 15, 2024

Description: Adding a new component to Splunk Distribution of the Opentelemetry Collector.

Link to Splunk idea: #4980

Testing:

Documentation:

@samiura samiura marked this pull request as ready for review June 15, 2024 00:28
@samiura samiura requested review from a team as code owners June 15, 2024 00:28
Copy link
Contributor

@jeffreyc-splunk jeffreyc-splunk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the changelog.

CHANGELOG.md Outdated
@@ -2,6 +2,10 @@

## Unreleased

### 🚀 New components 🚀

- (Splunk) Add RabbitMQ receiver ([#4980](https://github.com/signalfx/splunk-otel-collector/pull/4980))
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Are there any limitations?
  • How does this compare to the collectd/rabbitmq smartagent receiver?

Copy link
Contributor Author

@samiura samiura Jun 17, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the native RabbitMQ receiver from the contrib. I believe the docs team will document this. I am not aware of the collectd/rabbitq to be honest. But the goal is oneday to remove
it.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also like other native receivers that we have brought in ( for e.g. Mongodb, MySQL), usually docs team reflect the offical contrib documentation of the respective receiver.
https://github.com/open-telemetry/opentelemetry-collector-contrib/tree/main/receiver/rabbitmqreceiver

@samiura samiura force-pushed the otl-2776 branch 4 times, most recently from 7c8a35b to 3a4760d Compare June 17, 2024 18:21
@samiura samiura force-pushed the otl-2776 branch 2 times, most recently from afa1f4b to 74a8001 Compare June 17, 2024 20:31
@samiura samiura merged commit 2de401f into main Jun 17, 2024
16 checks passed
@samiura samiura deleted the otl-2776 branch June 17, 2024 20:33
@github-actions github-actions bot locked and limited conversation to collaborators Jun 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants