Capture visibility events #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| this.unloading = false; | ||
| } | ||
|
|
||
| // eslint-disable-next-line @typescript-eslint/no-empty-function |
There was a problem hiding this comment.
Can this be configured in eslint? Especially, if all instances of InstrumentationBase require init() to be present.
There was a problem hiding this comment.
Switched off globally
| import { VERSION } from './version'; | ||
|
|
||
| const MODULE_NAME = 'splunk-visibility'; | ||
| let visibilityListener: any; |
There was a problem hiding this comment.
Can these listeners be fields of the instrumentation?
| }); | ||
| browser.globals.emulateTabSwitching = async (visible) => { | ||
| await browser.execute((hidden) => { | ||
| Object.defineProperty(document, 'hidden', { value: hidden, configurable: true }); |
There was a problem hiding this comment.
Looking at this, I'd suggest we make it a unit test. This isn't how an integration test should work.
There was a problem hiding this comment.
Will look into making it a real integration test with a real tab switch at some point
jtmal-signalfx
approved these changes
Jul 26, 2021
t2t2
approved these changes
Jul 27, 2021
sfishel-splunk
pushed a commit
to sfishel-splunk/splunk-otel-js-web
that referenced
this pull request
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Captured as 0 duration spans as these can't be complete spans(due to us not being able to close some of them in some case) and we don't have events. Disabled for now cause we need to make sure that sending them is fine. At some point we probably need to add this info to each span so data can be filtered in UI.
Code in index.ts is moved cause otherwise some things fire at wrong times.