Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: set the GDI-spec compliant defs and warn about missing service.name #344

Merged
merged 5 commits into from
Oct 8, 2021

Conversation

rauno56
Copy link
Contributor

@rauno56 rauno56 commented Oct 6, 2021

  • feat: set the defaults on limits
  • feat: warn about missing service.name and no instrumentations

Description

Addresses some of the concerns from GDI spec review.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Internal change (a change which is not visible to the package consumers)
  • Added automated tests
  • Unit tests have been added/updated
  • Documentation has been updated
  • Change file has been generated (npm run change:new)
  • Delete this branch (after the PR is merged)

@codecov-commenter
Copy link

codecov-commenter commented Oct 6, 2021

Codecov Report

Merging #344 (ad33e44) into main (0b7a6d9) will increase coverage by 0.15%.
The diff coverage is 100.00%.

❗ Current head ad33e44 differs from pull request most recent head 1f08bae. Consider uploading reports for the commit 1f08bae to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##             main     #344      +/-   ##
==========================================
+ Coverage   93.89%   94.05%   +0.15%     
==========================================
  Files          10       10              
  Lines         344      353       +9     
  Branches       89       93       +4     
==========================================
+ Hits          323      332       +9     
  Misses         21       21              
Impacted Files Coverage Δ
src/options.ts 99.02% <100.00%> (+0.09%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0b7a6d9...1f08bae. Read the comment docs.

@rauno56 rauno56 marked this pull request as ready for review October 7, 2021 06:32
@rauno56 rauno56 requested review from a team as code owners October 7, 2021 06:32
defaultServiceName;
resource.attributes[SemanticResourceAttributes.SERVICE_NAME];

if (!serviceName) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is diag.warn visible in the terminal as well?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Only if it's enabled.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll merge it, @seemk, but any comments are still welcome!

Copy link
Contributor

@owais owais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mistake in docs. Looks good otherwise.

docs/advanced-config.md Outdated Show resolved Hide resolved
docs/advanced-config.md Outdated Show resolved Hide resolved
@rauno56 rauno56 merged commit 9d9e18f into signalfx:main Oct 8, 2021
@rauno56 rauno56 deleted the feat/overwrite-defs branch October 8, 2021 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants