Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Retrieve mmsi from the full model #11

Closed
tkurki opened this issue Jan 28, 2018 · 2 comments
Closed

Retrieve mmsi from the full model #11

tkurki opened this issue Jan 28, 2018 · 2 comments

Comments

@tkurki
Copy link
Member

tkurki commented Jan 28, 2018

This no longer works with the current server because of changes in the configuration method.

It should try to retrieve mmsi from the full model so that it is independent from the configuration method. It could also try to retrieve the mmsi every once in a while so that a server restart or disable/enable cycle is not necessary.

@stevepmitchell
Copy link

stevepmitchell commented Feb 3, 2018

Could this be why when I try to use this, SignalK crashes with an error about not being able to read an MMSI value?

`Feb 3 06:38:38 grace signalk-server[11819]: /usr/lib/node_modules/signalk-server/node_modules/@signalk/aisreporter/index.js:31

Feb 3 06:38:38 grace signalk-server[11819]: var mmsi = app.config.settings.vessel.mmsi
Feb 3 06:38:38 grace signalk-server[11819]: ^

Feb 3 06:38:38 grace signalk-server[11819]: TypeError: Cannot read property 'mmsi' of undefined
Feb 3 06:38:38 grace signalk-server[11819]: at Object.plugin.start (/usr/lib/node_modules/signalk-server/node_modules/@signalk/aisreporter/index.js:31:42)
Feb 3 06:38:38 grace signalk-server[11819]: at err (/usr/lib/node_modules/signalk-server/lib/interfaces/plugins.js:179:18)
Feb 3 06:38:38 grace signalk-server[11819]: at FSReqWrap.oncomplete (fs.js:123:15)`

@tkurki
Copy link
Member Author

tkurki commented Feb 12, 2018

This should now be fixed in version 0.0.4.

@tkurki tkurki closed this as completed Oct 10, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants